menu: Guard against NULL toplevel

This can happen, as indicated by GtkMenu explicitly connecting to
::destroy of its toplevel window. Do the same thing in GtkComboBox.

diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c
index 2946ececa823d9efd5ba72198e7db5581e1ede47..cf01278db5d831fac94589a938273a9efbf70d81 100644 (file)
--- a/gtk/gtkcombobox.c
+++ b/gtk/gtkcombobox.c
@@ -1790,12 +1790,15 @@ gtk_combo_box_detacher (GtkWidget *widget,
 
   g_return_if_fail (priv->popup_widget == (GtkWidget *) menu);
 
-  g_signal_handlers_disconnect_by_func (menu->priv->toplevel,
-                                        gtk_combo_box_menu_show,
-                                        combo_box);
-  g_signal_handlers_disconnect_by_func (menu->priv->toplevel,
-                                        gtk_combo_box_menu_hide,
-                                        combo_box);
+  if (menu->priv->toplevel)
+    {
+      g_signal_handlers_disconnect_by_func (menu->priv->toplevel,
+                                            gtk_combo_box_menu_show,
+                                            combo_box);
+      g_signal_handlers_disconnect_by_func (menu->priv->toplevel,
+                                            gtk_combo_box_menu_hide,
+                                            combo_box);
+    }
 
   priv->popup_widget = NULL;
 }

diff --git a/gtk/gtkmenu.c b/gtk/gtkmenu.c
index c443cfeb22d8703e26e35d6cae1a42c18c5bce87..81080e9067bf7905c5cd1c0a62981206290f38b4 100644 (file)
--- a/gtk/gtkmenu.c
+++ b/gtk/gtkmenu.c
@@ -1625,11 +1625,14 @@ gtk_menu_detach (GtkMenu *menu)
   g_object_set_data (G_OBJECT (menu), I_(attach_data_key), NULL);
 
   /* Detach the toplevel window. */
-  g_signal_handlers_disconnect_by_func (toplevel,
-                                        (gpointer) menu_toplevel_attached_to,
-                                        menu);
-  if (gtk_window_get_attached_to (toplevel) == data->attach_widget)
-    gtk_window_set_attached_to (toplevel, NULL);
+  if (toplevel)
+    {
+      g_signal_handlers_disconnect_by_func (toplevel,
+                                            (gpointer) menu_toplevel_attached_to,
+                                            menu);
+      if (gtk_window_get_attached_to (toplevel) == data->attach_widget)
+        gtk_window_set_attached_to (toplevel, NULL);
+    }
 
   g_signal_handlers_disconnect_by_func (data->attach_widget,
                                         (gpointer) attach_widget_screen_changed,